Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ∞ GramMatrix #259

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Support ∞ GramMatrix #259

wants to merge 2 commits into from

Conversation

dlfivefifty
Copy link
Member

This will also make a number of other changes, eg. making GramMatrix lazy that can be materialized via BandedMatrix(GramMatrix(μ, X)).

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (a40b3dc) to head (b4553f4).

Files with missing lines Patch % Lines
src/GramMatrix.jl 0.00% 8 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a40b3dc) and HEAD (b4553f4). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (a40b3dc) HEAD (b4553f4)
13 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #259       +/-   ##
==========================================
- Coverage   77.12%   0.00%   -77.13%     
==========================================
  Files          17      17               
  Lines        3156    3098       -58     
==========================================
- Hits         2434       0     -2434     
- Misses        722    3098     +2376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member Author

@MikaelSlevinsky Why does the moment-based constructor only use half the entries?

@dlfivefifty
Copy link
Member Author

I don't understand the rational for the truncation behaviour. Eg in the banded unit test, why can't we have the gram matrix represent I+X^2 + X^4 instead of (I+X^2+X^4)[1:n,1:n]?

I get that truncating is throwing out the truncation error. But this seems too clever. That is, I don't think GramMatrix should try to do things ∞-dimensional (unless X itself is ∞-dimensional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant