Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocks in popfirst #344

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Fix blocks in popfirst #344

merged 1 commit into from
Mar 21, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 21, 2024

Fixes the following behaviour on master:

julia> B = BlockArray([1:6;], [2,2,2])
3-blocked 6-element BlockVector{Int64}:
 1
 23
 45
 6

julia> popfirst!(B)
1

julia> B
3-blocked 6-element BlockVector{Int64}:
               2
 ───────────────
               3
               4
 139721335802992
 ───────────────
               5
               6

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (ea33af1) to head (29404a3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   92.66%   93.06%   +0.40%     
==========================================
  Files          16       16              
  Lines        1499     1499              
==========================================
+ Hits         1389     1395       +6     
+ Misses        110      104       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit f87ad0c into master Mar 21, 2024
13 checks passed
@jishnub jishnub deleted the jishnub/popfirst branch March 21, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant