-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize BlockArray/BlockedArray to non-integer block lengths #405
Generalize BlockArray/BlockedArray to non-integer block lengths #405
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 94.99% 96.25% +1.25%
==========================================
Files 16 18 +2
Lines 1498 1628 +130
==========================================
+ Hits 1423 1567 +144
+ Misses 75 61 -14 ☔ View full report in Codecov by Sentry. |
Looks like there are some code coverage issues. Oddly those are not new lines of code but just ones that were modified by this PR, I guess they weren't covered before and modifying them triggered those coverage comments. |
It would be great if you can add tests even if its not your fault they weren't covered |
Will do. |
There's a few more code coverage issues to fix. Also I realized I need to rework the |
Ok, I redesigned I think there are a few more subtle places throughout the library that are hardcoded to |
I noticed that there was a lot of code in blockaxis.jl that is still hardcoded to |
Ok, this is ready from my end. |
The element types of
BlockedUnitRange
/BlockedOneTo
were generalized to anyInteger
type in BlockArrays v1 (#255, #337, #395). However, the axes ofBlockArray
andBlockedArray
are still hardcoded to have element typeInt
. This PR lifts that restriction.Note that currently there is an issue printing very large BlockArray/BlockedArray:
This appears to be a Base Julia issue, see JuliaLang/julia#54786.