-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zero dimensional BlockArray and BlockedArray #410
Conversation
I implemented @dlfivefifty suggestions to fix |
For a zero-dimensional Array, |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 96.25% 96.66% +0.41%
==========================================
Files 18 18
Lines 1628 1649 +21
==========================================
+ Hits 1567 1594 +27
+ Misses 61 55 -6 ☔ View full report in Codecov by Sentry. |
Can you get the codecov up? downstream failure looks spurious |
Should be fine now. Also realized |
This PR seems to add many methods. Do we really need them all? E.g. the |
I double checked, there were 3 changes that were not necessary. Reverting any other change breaks the tests. |
Fixes #409 and add tests.
BlockArrays
are now fine, howeverBlockedArray
are still broken. This is due to the type piracy onview
mentioned in #409. I do not see how to fix it at the moment.