Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve axes in similar for BlockArrays #422

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Oct 16, 2024

Fixes #420

After this,

julia> using BlockArrays

julia> using BlockArrays: BlockedOneTo

julia> b = BlockVector([1,2,3,4,5,6,7,8,9,10], (BlockedOneTo(5:5:10),));

julia> typeof(b) == typeof(zero(b))
true

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (836da5c) to head (1ce8185).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   96.66%   96.47%   -0.19%     
==========================================
  Files          18       18              
  Lines        1649     1647       -2     
==========================================
- Hits         1594     1589       -5     
- Misses         55       58       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 1e5feaa into master Oct 29, 2024
14 of 15 checks passed
@jishnub jishnub deleted the jishnub/similar_axes branch October 29, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typeof(zero(x)) != typeof(x) for BlockVector
1 participant