Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Demonstration of LazyArrays extension loading issue #433

Closed
wants to merge 4 commits into from

Conversation

mtfishman
Copy link
Collaborator

As discussed in #431, this PR is meant to demonstrate an issue loading the LazyArraysBlockArraysExt package extension in Julia v1.11.1 and the v1.11.2 pre-release.

As a summary, I've tried running the downstream tests against a few Julia versions, here are the results:

  • Julia v1.11.0: All tests pass.
  • Julia v1.11.1: LazyArrays.jl tests fail when LazyArraysBlockArraysExt is being loaded with the error "ERROR: LoadError: ArgumentError: Package LazyArraysBlockArraysExt does not have BlockArrays in its dependencies", all others pass.
  • Julia v1.11.2 pre-release: LazyArrays.jl tests fail with the same error as in Julia v1.11.1, all others pass. I tested it by setting 1.11-nightly in the workflow.
  • Julia nightly: The last time I checked LazyArrays.jl tests ran properly (so the original issue plaguing Julia v1.11.1 and v1.11.2 is fixed) but failed for another independent reason.

I haven't been able to reproduce this locally so this PR is the best I could do to demonstrate the issue. It seems like there is an issue in Julia v1.11.1 that is still in the v1.11.2 pre-release related to package extension loading.

As discussed in #431, this PR is meant to demonstrate an issue loading the LazyArraysBlockArraysExt package extension in Julia v1.11.1 and the v1.11.2 pre-release.

As a summary, I've tried running the downstream tests against a few Julia versions, here are the results:

- Julia v1.11.0: All tests pass.
- Julia v1.11.1: LazyArrays.jl tests fail when LazyArraysBlockArraysExt is being loaded with the error "ERROR: LoadError: ArgumentError: Package LazyArraysBlockArraysExt does not have BlockArrays in its dependencies", all others pass.
- [Julia v1.11.2 pre-release](https://discourse.julialang.org/t/julia-v1-11-2-testing-period/122943): LazyArrays.jl tests fail with the same error as in Julia v1.11.1, all others pass. I tested it by setting `1.11-nightly` in the workflow.
- Julia nightly: The last time I checked LazyArrays.jl tests ran properly (so the original issue plaguing Julia v1.11.1 and v1.11.2 is fixed) but failed for another independent reason.

I haven't been able to reproduce this locally so this PR is the best I could do to demonstrate the issue. It seems like there is an issue in Julia v1.11.1 that is still in the v1.11.2 pre-release related to package extension loading.
@mtfishman mtfishman marked this pull request as draft November 22, 2024 16:16
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.55%. Comparing base (cc46573) to head (19c9fef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          18       18           
  Lines        1644     1644           
=======================================
  Hits         1538     1538           
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub
Copy link
Member

jishnub commented Dec 5, 2024

Should be fixed now on v1.11.2

@mtfishman mtfishman closed this Dec 5, 2024
@mtfishman mtfishman reopened this Dec 5, 2024
@jishnub
Copy link
Member

jishnub commented Dec 5, 2024

Rebasing on master should fix the broken test.

@mtfishman
Copy link
Collaborator Author

Ok, looks like everything works now, I'll close this PR.

@mtfishman mtfishman closed this Dec 6, 2024
@mtfishman mtfishman deleted the lazyarrays-ext-load-failure branch December 6, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants