Fast bounds-check for infinite CartesianIndex StepRangeLen #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia v1.11 allows
StepRangeLen{<:CartesianIndex}
indices, but the bounds-check for such a range falls back to element-wise iteration. The other issue with such an infinite range is thatlast
can't be defined as aCartesianIndex
, as it only acceptsInt
s.In this PR, we define
checkindex
for such indices by only comparing the starting point. This would allow bounds-checking for infinite arrays with such indices.