Remove backwards compatibility package extension logic#347
Remove backwards compatibility package extension logic#347dlfivefifty merged 2 commits intoJuliaArrays:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 17 17
Lines 3155 3155
=======================================
Hits 3018 3018
Misses 137 137 ☔ View full report in Codecov by Sentry. |
|
Thanks. Just curious is there any negative impact on including them as both dependencies and weak dependencies? |
I think in principle it shouldn't, though my guess is that it will fix the test failure related to |
|
As a more obvious downside of listing them as both dependencies and weak dependencies, didn't that cause those packages ( |
Some weakdeps were listed as deps so that package extensions could be loaded in older Julia versions, which doesn't seem necessary now since LazyArrays.jl requires Julia 1.10. See also JuliaArrays/BlockArrays.jl#431.