-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More IdOffsetRange broadcasting #292
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 95.67% 96.42% +0.75%
==========================================
Files 5 5
Lines 439 448 +9
==========================================
+ Hits 420 432 +12
+ Misses 19 16 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if promoting to OffsetVector
is a wanted outcome. Do you have some real applications to illustrate this more?
I don't really have an application in mind, this was more about making an offset range and an offset vector behave identically. Currently, we don't have an |
@jishnub I just removed the review request from |
Fix an overflow issue with broadcasting over
IdOffsetRange
, and add more methods that exist forBase
ranges: