Skip to content

Conversation

@siddharthlal25
Copy link
Member

This PR will mostly be taken from #30 with some minor modifications.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #33 into master will increase coverage by 3.20%.
The diff coverage is 88.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   88.14%   91.35%   +3.20%     
==========================================
  Files           5        5              
  Lines         135      185      +50     
==========================================
+ Hits          119      169      +50     
  Misses         16       16              
Impacted Files Coverage Δ
src/CCDReduction.jl 100.00% <ø> (ø)
src/collection.jl 87.20% <88.33%> (+17.76%) ⬆️
src/fits.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c7cf1...fe5c750. Read the comment docs.

@siddharthlal25
Copy link
Member Author

I will rename df to collection at the end of the PR to keep the diff clean for reviewing.

@siddharthlal25
Copy link
Member Author

@mileslucas @giordano this one is ready for review! Let me know your thoughts about the code.

@siddharthlal25
Copy link
Member Author

I have made a small change, I have exported the functions data and hdr to be accessible by the user for convenience and uniform interface. Thoughts?

@siddharthlal25
Copy link
Member Author

I am merging this one! Thanks for the help and reviews!

@siddharthlal25 siddharthlal25 merged commit af2a4af into JuliaAstro:master Aug 26, 2020
@siddharthlal25 siddharthlal25 deleted the gen branch October 4, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants