Skip to content

Move fitsfile to correct HDU in indexing #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 26, 2025

Otherwise, the HDU being read doesn't correspond to the index.

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (695eb7d) to head (8b4728f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   91.27%   91.29%   +0.01%     
==========================================
  Files           5        5              
  Lines         688      689       +1     
==========================================
+ Hits          628      629       +1     
  Misses         60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit f380e2c into master May 26, 2025
15 checks passed
@jishnub jishnub deleted the jishnub/indexing_movabs branch May 26, 2025 07:09
@aplavin
Copy link
Contributor

aplavin commented May 26, 2025

What does it mean exactly? Was getindex wrong before?

@jishnub
Copy link
Member Author

jishnub commented May 26, 2025

It fixes a bug introduced on master in 9b7edf4, where the fits_movabs_hdu was missed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants