Skip to content

Conversation

@matthias314
Copy link

@matthias314 matthias314 commented Dec 25, 2025

I think it makes sense that menu.current points to the current menu item when the user-defined keypress function is called for a TreeMenu. Currently this is not the case unless the key is space. In this case the current menu item is needed to process the key press correctly, and user-defined keypress functions will often be in the same situation.

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (86789ee) to head (3d7dff8).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          156       153    -3     
=========================================
- Hits           156       153    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthias314
Copy link
Author

I've added a second commit that likewise updates menu.pagesize after calling menu.keypress because that function may modify the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant