Add FFT convolution kernels #638
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft for adding FFT convolution kernels (that are also plans), which are useful for repeated convolutions.
A lot has been adapted from the code here, courtesy of @JanJereczek
Here's what I have done so far:
FFTConvKernel
, subtypesR/CFFTConvKernel
Array
, FFTW flag defaults to FFTW.MEASUREout[output_indices]
doesn't throw) before doing work except for:direct
, so I added that. Don't remember if we have discussed this before, so left it in just in casex
, maybe larger depending onnffts
A typical workflow goes like this:
outsize
, the size of the intended outputsize(out) .+ size(ker) .- 1
RFFTConvKernel
orCFFTConvKernel(kernel, outsize)
conv!(out[i], arrs[i], kernel)
in a loopFeedback would be much appreciated