-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add io_context
keyword argument
#26
Conversation
CI failure will require #27 to fix first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pretty much LGTM, just a couple of suggestions. Feel free to add a CHANGELOG entry and bump the version, and we can get this tagged quickly.
I'm open to alternative namings of
io_context
, which seemed to most reasonable to match the rest of the keywords.
My initial gut reaction was iocontext
, without the underscore, to match the IOContext
type. But io_context
is fine as well, so I'll leave that up to you.
I'll leave it as |
8cde5ff
to
2cd5eac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @MichaelHatherly!
Thanks @mortenpi |
Over in PumasAI/QuartoNotebookRunner.jl#143 @jkrumbiegel and I were trying to work out the most straightforward way to get the printing "correct" for types. This seems to be pretty straightforward to me.
I'm open to alternative namings of
io_context
, which seemed to most reasonable to match the rest of the keywords.