Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io_context keyword argument #26

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add io_context keyword argument #26

merged 1 commit into from
Jun 12, 2024

Conversation

MichaelHatherly
Copy link
Member

Over in PumasAI/QuartoNotebookRunner.jl#143 @jkrumbiegel and I were trying to work out the most straightforward way to get the printing "correct" for types. This seems to be pretty straightforward to me.

I'm open to alternative namings of io_context, which seemed to most reasonable to match the rest of the keywords.

@MichaelHatherly
Copy link
Member Author

CI failure will require #27 to fix first.

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pretty much LGTM, just a couple of suggestions. Feel free to add a CHANGELOG entry and bump the version, and we can get this tagged quickly.

I'm open to alternative namings of io_context, which seemed to most reasonable to match the rest of the keywords.

My initial gut reaction was iocontext, without the underscore, to match the IOContext type. But io_context is fine as well, so I'll leave that up to you.

src/IOCapture.jl Outdated Show resolved Hide resolved
src/IOCapture.jl Show resolved Hide resolved
@MichaelHatherly
Copy link
Member Author

My initial gut reaction was iocontext, without the underscore, to match the IOContext type. But io_context is fine as well, so I'll leave that up to you.

I'll leave it as io_context, my reasoning being that IOContext is "IO Context" camelcased, so the lowercasing of that to snakecase should be io_context to preserve the two "words".

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MichaelHatherly!

@mortenpi mortenpi merged commit 2ccb546 into master Jun 12, 2024
30 checks passed
@mortenpi mortenpi deleted the mh/io_context branch June 12, 2024 23:14
@mortenpi
Copy link
Member

@MichaelHatherly
Copy link
Member Author

Thanks @mortenpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants