Use lazy iterator to ensure all rings in create_[a/b]_list are closed#195
Open
asinghvi17 wants to merge 14 commits intomainfrom
Open
Use lazy iterator to ensure all rings in create_[a/b]_list are closed#195asinghvi17 wants to merge 14 commits intomainfrom
create_[a/b]_list are closed#195asinghvi17 wants to merge 14 commits intomainfrom
Conversation
Member
Author
|
Ah, this breaks cut output because cut relies on the second ring not being closed. Maybe we have a pass through wrapper DontFix{T} for situations like this one? I could also make the lazy closed ring wrapper and wrap everything in intersection, difference, and union in that. In retrospect this seems like a better plan. |
Member
|
We may need a dedicated wrapper type for this to be fast. |
Member
Author
|
Tests fail because this doesn't handle empty rings (I guess that it should be an empty ring in that case...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #191 by ensuring that an extra point is effectively "vcat"'ed onto the stack, in case the polygon ring is not closed.
At some point this will change to use whatever struct we implement for the lazy polygon winding order / lazy polygon closed ring stuff, but for now this seems fit for purpose.