-
Notifications
You must be signed in to change notification settings - Fork 5
CompatHelper: bump compat for CoordRefSystems to 0.18, (keep existing compat) #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for CoordRefSystems to 0.18, (keep existing compat) #180
Conversation
ad6bbce
to
96d2210
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 181 181
=========================================
Hits 181 181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
…t, (keep existing compat) (#181) Co-authored-by: CompatHelper Julia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to bump the compat of Enzyme.jl to make downgrade happy. In v0.13.45, RNumber
was removed. So I guess, we need to use that as compat. Let's see what CI says.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, Enzyme.jl v0.13.45 needs ages to precompile (also tested locally). Enzyme.jl v0.13.47 seems to be better. Let's try that.
This pull request changes the compat entry for the
CoordRefSystems
package from0.15, 0.16, 0.17
to0.15, 0.16, 0.17, 0.18
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.