Skip to content

CompatHelper: bump compat for CoordRefSystems to 0.18, (keep existing compat) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CoordRefSystems package from 0.15, 0.16, 0.17 to 0.15, 0.16, 0.17, 0.18.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@mikeingold mikeingold force-pushed the compathelper/new_version/2025-06-12-01-09-59-721-01756008997 branch from ad6bbce to 96d2210 Compare June 12, 2025 01:10
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (375052a) to head (7630c03).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          181       181           
=========================================
  Hits           181       181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor Author

github-actions bot commented Jun 12, 2025

Benchmark Results

main 7630c03... main / 7630c03...
Differentials/Differential 0.204 ± 0.0011 μs 0.205 ± 0.002 μs 0.995 ± 0.011
Differentials/Jacobian 0.177 ± 0.001 μs 0.169 ± 0.0011 μs 1.05 ± 0.009
Integrals/Segment/Scalar GaussKronrod 0.557 ± 0.005 μs 0.552 ± 0.0081 μs 1.01 ± 0.017
Integrals/Segment/Scalar GaussLegendre 1.62 ± 0.0069 μs 1.64 ± 0.008 μs 0.987 ± 0.0064
Integrals/Segment/Scalar HAdaptiveCubature 0.725 ± 0.015 μs 0.685 ± 0.013 μs 1.06 ± 0.03
Integrals/Segment/Vector GaussKronrod 2.74 ± 0.075 μs 2.77 ± 0.076 μs 0.988 ± 0.038
Integrals/Segment/Vector GaussLegendre 17.9 ± 0.59 μs 18.1 ± 0.65 μs 0.99 ± 0.048
Integrals/Segment/Vector HAdaptiveCubature 3.64 ± 0.16 μs 3.62 ± 0.11 μs 1 ± 0.052
Integrals/Sphere/Scalar GaussKronrod 0.0682 ± 0.0016 ms 0.0681 ± 0.0011 ms 1 ± 0.029
Integrals/Sphere/Scalar GaussLegendre 1.87 ± 0.0096 ms 1.87 ± 0.01 ms 1 ± 0.0074
Integrals/Sphere/Scalar HAdaptiveCubature 0.048 ± 0.00014 ms 0.0476 ± 0.00011 ms 1.01 ± 0.0038
Integrals/Sphere/Vector GaussKronrod 0.103 ± 0.0019 ms 0.104 ± 0.002 ms 0.99 ± 0.027
Integrals/Sphere/Vector GaussLegendre 3.33 ± 0.084 ms 3.43 ± 0.069 ms 0.972 ± 0.031
Integrals/Sphere/Vector HAdaptiveCubature 0.0995 ± 0.0022 ms 0.0999 ± 0.0021 ms 0.996 ± 0.03
Rules/GaussLegendre 22.1 ± 0.52 μs 22 ± 0.54 μs 1.01 ± 0.034
Specializations/Scalar GaussLegendre/BezierCurve 0.252 ± 0.0079 ms 0.251 ± 0.0071 ms 1 ± 0.042
Specializations/Scalar GaussLegendre/Line 6.97 ± 0.074 μs 6.96 ± 0.058 μs 1 ± 0.014
Specializations/Scalar GaussLegendre/Plane 0.745 ± 0.0024 ms 0.745 ± 0.0018 ms 1 ± 0.004
Specializations/Scalar GaussLegendre/Ray 5.88 ± 0.063 μs 5.84 ± 0.05 μs 1.01 ± 0.014
Specializations/Scalar GaussLegendre/Rope 0.0508 ± 0.00025 ms 0.0513 ± 0.00029 ms 0.99 ± 0.0074
Specializations/Scalar GaussLegendre/Tetrahedron 0.158 ± 0.0018 s 0.157 ± 0.0014 s 1.01 ± 0.015
Specializations/Scalar GaussLegendre/Triangle 0.606 ± 0.0075 ms 0.616 ± 0.0077 ms 0.984 ± 0.017
time_to_load 1.51 ± 0.036 s 1.49 ± 0.016 s 1.01 ± 0.026

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

…t, (keep existing compat) (#181)

Co-authored-by: CompatHelper Julia <[email protected]>
Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to bump the compat of Enzyme.jl to make downgrade happy. In v0.13.45, RNumber was removed. So I guess, we need to use that as compat. Let's see what CI says.

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Enzyme.jl v0.13.45 needs ages to precompile (also tested locally). Enzyme.jl v0.13.47 seems to be better. Let's try that.

@JoshuaLampert JoshuaLampert merged commit 6ebfbcd into main Jun 12, 2025
12 checks passed
@JoshuaLampert JoshuaLampert deleted the compathelper/new_version/2025-06-12-01-09-59-721-01756008997 branch June 12, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant