Skip to content

README improvements #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 12, 2024
Merged

README improvements #70

merged 10 commits into from
Sep 12, 2024

Conversation

mikeingold
Copy link
Collaborator

No description provided.

@mikeingold
Copy link
Collaborator Author

@JoshuaLampert let me know what you think of the updated README in this branch.

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good!

mikeingold and others added 3 commits September 9, 2024 09:15
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
@mikeingold mikeingold changed the title Documentation improvements README improvements Sep 9, 2024
@mikeingold
Copy link
Collaborator Author

@JoshuaLampert do you have an opinion on bumping the package version within this PR vs separately? I’ve currently got the main branch protected from direct commits so it’s a bit extra overhead to PR a version bump alone.

@mikeingold mikeingold marked this pull request as ready for review September 12, 2024 18:52
@JoshuaLampert
Copy link
Member

It's totally fine to bump the version number in this PR.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.85%. Comparing base (46d1c4a) to head (d0529bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           7        7           
  Lines         353      353           
=======================================
  Hits          296      296           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeingold
Copy link
Collaborator Author

Am I missing any review items? I’m still seeing a flag for 1 missing suggestion but everything looks resolved on my end.

Copy link
Member

@JoshuaLampert JoshuaLampert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert merged commit 8813827 into main Sep 12, 2024
6 checks passed
@JoshuaLampert
Copy link
Member

Everything looks fine on my end.

@mikeingold
Copy link
Collaborator Author

Great. Thanks!

@JoshuaLampert
Copy link
Member

Oh, I wanted to enable auto-merge, but missed that CI is not a required status check. I suggest to make passing CI required.

@mikeingold mikeingold deleted the better-docs branch September 12, 2024 19:37
@JoshuaLampert JoshuaLampert added the documentation Improvements or additions to documentation label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants