-
Notifications
You must be signed in to change notification settings - Fork 5
README improvements #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@JoshuaLampert let me know what you think of the updated README in this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
Co-authored-by: Joshua Lampert <[email protected]>
@JoshuaLampert do you have an opinion on bumping the package version within this PR vs separately? I’ve currently got the main branch protected from direct commits so it’s a bit extra overhead to PR a version bump alone. |
It's totally fine to bump the version number in this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
=======================================
Coverage 83.85% 83.85%
=======================================
Files 7 7
Lines 353 353
=======================================
Hits 296 296
Misses 57 57 ☔ View full report in Codecov by Sentry. |
Am I missing any review items? I’m still seeing a flag for 1 missing suggestion but everything looks resolved on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Everything looks fine on my end. |
Great. Thanks! |
Oh, I wanted to enable auto-merge, but missed that CI is not a required status check. I suggest to make passing CI required. |
No description provided.