Code

Add Bentley-Ottman Algorithm #1168

Code

Open

souma4 wants to merge 63 commits intoJuliaGeometry:masterJuliaGeometry/Meshes.jl:masterfrom

souma4:JRC_add_BentleyOttmansouma4/Meshes.jl:JRC_add_BentleyOttmanCopy head branch name to clipboard

Commits

Commits on Feb 11, 2025

• add test segment. proper test later

  souma4

  committed
  c5a3b90

  Copy full SHA for c5a3b90

• Clean single commit for BentleyOttman algorithm. Essentially, it outputs a dictionary of vertex keys with segment values

  souma4

  committed
  e004810

  Copy full SHA for e004810

• test for valid answer

  souma4

  committed
  491a130

  Copy full SHA for 491a130

• moved sweepline algorithm to Intersections since it is dependent on intersections and ultimately calculates all intersections

  souma4

  committed
  840c1a5

  Copy full SHA for 840c1a5

Commits on Feb 17, 2025

• Update Doc for bentley ottman implementation to specify output

  souma4

  committed
  6f018a3

  Copy full SHA for 6f018a3

• update project.toml to include BinaryTrees dependency

  souma4

  committed
  eb0d56b

  Copy full SHA for eb0d56b

Commits on Feb 24, 2025

• major commit. Moved sweepline from intersections to utils along with tests. Edited test to be more intensive. updated entire script to meet style and Julia best practices. Removed unneded functions…

  Show description for b869b6e
  souma4

  committed
  b869b6e

  Copy full SHA for b869b6e

• new_type and new_geom didn't meet style, so fixed. Removed an unneeded function. removed println calls used for debugging

  souma4

  committed
  6be63f1

  Copy full SHA for 6be63f1

• forgot to rename _intersection to _pushintersection

  souma4

  committed
  ed09d87

  Copy full SHA for ed09d87

Commits on Mar 4, 2025

• small commits to improve compatibility and fix mixed up old names

  Show description for 2b83b1a
  

  souma4

  and

  juliohm

  authored
  2b83b1a

  Copy full SHA for 2b83b1a

Commits on Mar 6, 2025

• small updates to License text, cases, variable and function names, cleaner enum handling, and shifted the final dictionary to be unique values

  souma4

  committed
  7484dc1

  Copy full SHA for 7484dc1

• Merge branch 'JRC_add_BentleyOttman' of https://github.com/souma4/Meshes.jl into JRC_add_BentleyOttman

  souma4

  committed
  16791eb

  Copy full SHA for 16791eb

Commits on Mar 7, 2025

• Updated algorithm to be simpler, output is points and segment indices that connect to the point

  souma4

  committed
  ec4c593

  Copy full SHA for ec4c593

Commits on Mar 8, 2025

• updated tests to reflect changed output type

  souma4

  committed
  e18eb99

  Copy full SHA for e18eb99

Commits on Mar 9, 2025

• add compat for BinaryTrees

  souma4

  committed
  e27d9f1

  Copy full SHA for e27d9f1

• fixed names of variables and helper functions. removed output type from docstring

  souma4

  committed
  56018d3

  Copy full SHA for 56018d3

Commits on Mar 10, 2025

• updated utils include path and refactored if else to new function for easier edits if needed

  souma4

  committed
  442861b

  Copy full SHA for 442861b

• Minor adjustments before review

  juliohm

  authored
  0cc5d91

  Copy full SHA for 0cc5d91

Commits on Mar 11, 2025

• More fixes

  juliohm

  committed
  1c03947

  Copy full SHA for 1c03947

• changed S = Tuple{P, P} to V and changed the empty vectors of S to call the Vector function of type V

  souma4

  committed
  00e2151

  Copy full SHA for 00e2151

Commits on Mar 12, 2025

• the s iter variable was modified to segment using the same name, so my guess is it led to type instability. I removed redefinitions of s and just call Segment() as needed. Hopefully this stops s f…

  Show description for 83093e4
  souma4

  committed
  83093e4

  Copy full SHA for 83093e4

Commits on Mar 13, 2025

• Rename V -> S

  juliohm

  committed
  76d8be3

  Copy full SHA for 76d8be3

• More refactoring

  juliohm

  committed
  1e36abe

  Copy full SHA for 1e36abe

Commits on Mar 14, 2025

• Rename \scrT to \scrR to match paper notation, and avoid confusion with \scrI

  juliohm

  committed
  d590d36

  Copy full SHA for d590d36

• Refactor _newevent to improve readability

  juliohm

  committed
  93ce4a6

  Copy full SHA for 93ce4a6

• More refactoring to improve readability

  juliohm

  committed
  9fdaf93

  Copy full SHA for 9fdaf93

• More refactoring to improve readability and performance

  juliohm

  committed
  353cf70

  Copy full SHA for 353cf70

• More refactoring to improve readability

  juliohm

  committed
  d136b6e

  Copy full SHA for d136b6e

• More refactoring

  juliohm

  committed
  602a579

  Copy full SHA for 602a579

• More refactoring

  juliohm

  committed
  36e2497

  Copy full SHA for 36e2497

• More refactoring

  juliohm

  committed
  f5ff53e

  Copy full SHA for f5ff53e

• realigned more with original algorithm and reduced recomputation

  souma4

  committed
  0004c36

  Copy full SHA for 0004c36

• More refactoring

  juliohm

  committed
  dd88813

  Copy full SHA for dd88813

• More refactoring

  juliohm

  committed
  2fb7e10

  Copy full SHA for 2fb7e10

• More refactoring

  juliohm

  committed
  8e618e0

  Copy full SHA for 8e618e0

• More refactoring

  juliohm

  committed
  2850538

  Copy full SHA for 2850538

• Add more tests

  juliohm

  committed
  7762044

  Copy full SHA for 7762044

• Merge branch 'JuliaGeometry:master' into JRC_add_BentleyOttman

  souma4

  authored
  3f42e7d

  Copy full SHA for 3f42e7d

• edited the processing of intersections to better reflect the original algorithm and to reduce redundancy.

  souma4

  committed
  e288e23

  Copy full SHA for e288e23

Commits on Mar 15, 2025

• More refactoring

  juliohm

  committed
  5a21d3a

  Copy full SHA for 5a21d3a

• Refactor tests

  juliohm

  committed
  165ddae

  Copy full SHA for 165ddae

• Add more tests

  juliohm

  committed
  3ed853d

  Copy full SHA for 3ed853d

• Improve tests

  juliohm

  committed
  859c846

  Copy full SHA for 859c846

• Fix formatting

  juliohm

  committed
  9732322

  Copy full SHA for 9732322

• More refactoring

  juliohm

  committed
  98f0786

  Copy full SHA for 98f0786

• Add test with infinite loop

  juliohm

  committed
  042e690

  Copy full SHA for 042e690

• Fix formatting

  juliohm

  committed
  c9d933f

  Copy full SHA for c9d933f

• update to stop infinite loops, but has major TODOs to handle floating point issues

  souma4

  committed
  219add3

  Copy full SHA for 219add3

Commits on Mar 16, 2025

• reverting prior to dictionary implementation

  souma4

  committed
  89a8d98

  Copy full SHA for 89a8d98

Commits on Mar 17, 2025

• Merge branch 'JuliaGeometry:master' into JRC_add_BentleyOttman

  souma4

  authored
  3078412

  Copy full SHA for 3078412

• fully functioning not infinitely looping bentleyottman algorithm all passing tests locally

  souma4

  committed
  fdb936b

  Copy full SHA for fdb936b

• cleaned up test outputs and fixed tests to be T agnostic

  souma4

  committed
  5ef6505

  Copy full SHA for 5ef6505

Commits on Mar 19, 2025

• hopefully fixed failing test on Float32 values

  souma4

  committed
  33f2fba

  Copy full SHA for 33f2fba

• I think it's a precision issue, but T wasn't being handled how I thought it would so I'm just hard coding the Float32 tolerance.

  souma4

  committed
  e933e9c

  Copy full SHA for e933e9c

Commits on Mar 20, 2025

• shuffled to reduce redundant computations, particularly specifying the removal of ending segments from the status structure. My local tests suggest roughly logarithmic time, although caching from g…

  Show description for 5e972fc
  souma4

  committed
  5e972fc

  Copy full SHA for 5e972fc

• Minor adjustments

  juliohm

  authored
  0ed8c5f

  Copy full SHA for 0ed8c5f

• removed commented out useless code

  souma4

  committed
  0a18865

  Copy full SHA for 0a18865

Commits on Mar 21, 2025

• Minor adjustments

  juliohm

  committed
  e38d203

  Copy full SHA for e38d203

Commits on Mar 22, 2025

• Int is default type for integer literals

  Show description for 893fafd
  

  souma4

  and

  eliascarv

  authored
  893fafd

  Copy full SHA for 893fafd

• Set digits by default using exponent of absolute tolerance

  juliohm

  committed
  a10680b

  Copy full SHA for a10680b

• Decrease number of digits by one

  juliohm

  committed
  20178a3

  Copy full SHA for 20178a3

Commits on Mar 23, 2025

• updated script to be simpler. updated tests. THIS FAILS THE GRID TEST. EVENTS ARENT BEING HANDLED PROPERLY. I DONT HAVE TIME TO ADDRESS PROMPTLY

  souma4

  committed
  01604f1

  Copy full SHA for 01604f1

Commits on Mar 28, 2025

• WIP, With what little time I've had and will have for a bit, here's as far as I got with De Berg implementation. All tests fail. I think this is occuring between the status structure isn't reflecti…

  Show description for 8345d1e
  souma4

  committed
  8345d1e

  Copy full SHA for 8345d1e