Skip to content

Add Shadow transform #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Add Shadow transform #885

merged 9 commits into from
Jun 13, 2024

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Jun 13, 2024

Fix #884

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.18%. Comparing base (b037009) to head (144f603).

Files Patch % Lines
src/transforms/shadow.jl 94.73% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   88.13%   88.18%   +0.04%     
==========================================
  Files         173      174       +1     
  Lines        5199     5237      +38     
==========================================
+ Hits         4582     4618      +36     
- Misses        617      619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliascarv eliascarv changed the title [WIP] Add Shadow transform Add Shadow transform Jun 13, 2024
@eliascarv eliascarv requested a review from juliohm June 13, 2024 14:05
@eliascarv eliascarv marked this pull request as ready for review June 13, 2024 14:05
@eliascarv eliascarv requested a review from juliohm June 13, 2024 18:30
@juliohm juliohm merged commit 9dfe3a2 into master Jun 13, 2024
@juliohm juliohm deleted the shadow branch June 13, 2024 19:06
souma4 pushed a commit to souma4/Meshes.jl that referenced this pull request Feb 11, 2025
* Add 'Shadow' transform

* Apply suggestions

* Add tests

* Add comments

* Update tests

* Apply suggestions

* Apply suggestions

* Apply suggestions

* Apply suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Shadow transform to project onto lower-dimensional spaces
2 participants