Convert Requires based providers to Pkg extensions
#516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halleysfifthinc
force-pushed
the
weakdeps
branch
6 times, most recently
from
fd99a84 to
f702c03
Compare
halleysfifthinc
commented
Nov 14, 2024
| # TODO: change this to a permanent URL because this CSAIL account | ||
| # will eventually expire. | ||
| @test scope_import(w, "//people.csail.mit.edu/rdeits/webio_tests/trivial_import.js", use_iframe) == "ok" | ||
| @test scope_import(w, "//juliagizmos.github.io/WebIO.jl/dev/assets/trivial_import.js", use_iframe) == "ok" |
There was a problem hiding this comment.
These Blink tests will fail until a deployed version of the docs contains this .js file. If it's easier/preferred, I could split this and the related docs/CI updates out of this PR so that it could be merged first.
halleysfifthinc
force-pushed
the
weakdeps
branch
2 times, most recently
from
4cf5e53 to
c9474c2
Compare
- Mux tests were failing because the rdeits CSAIL account is expired
- Added the js file to the assets/ folder in the docs build to provide a
stable URI to test against
- (Explicitly add the js file so its removed/handled when switching
branches but should otherwise be ignored.)
- Bump versions for actions - Add `julia-actions/cache` - Update julia version's to new target minimum Julia
halleysfifthinc
force-pushed
the
weakdeps
branch
from
c9474c2 to
976ec33
Compare
|
Friendly bump! |
|
Bump |
|
Bump! Anyone with merge rights able to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using extensions results in slightly quicker load times for all extension packages, and it opens the door for a more convenient/seamless switch (or even co-existing) WebSockets => HTTP.WebSockets conversion.
master(with Julia 1.11.1)(Commits were kept independently functional to enable rebasing and help future bisecting if needed.)
(Supersedes) closes #478; closes #476.