Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve interval strings #215

Merged
merged 13 commits into from
Feb 24, 2017
Merged

Improve interval strings #215

merged 13 commits into from
Feb 24, 2017

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Feb 19, 2017

Towards #206.

Currently implemented:

  • @interval("[1]")
  • @interval("[-0x1.3p-1, 2/3]")
  • convert(DecoratedInterval{Float64}, "[1, 2]_dac")

@dpsanders
Copy link
Member Author

dpsanders commented Feb 19, 2017

I had to include #211 in this.
Removed again.

@codecov-io
Copy link

codecov-io commented Feb 19, 2017

Codecov Report

Merging #215 into master will increase coverage by 0.04%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage    90.3%   90.35%   +0.04%     
==========================================
  Files          23       24       +1     
  Lines        1001     1026      +25     
==========================================
+ Hits          904      927      +23     
- Misses         97       99       +2
Impacted Files Coverage Δ
src/ValidatedNumerics.jl 100% <ø> (ø)
src/intervals/conversion.jl 69.56% <100%> (-6.3%)
src/decorations/intervals.jl 84.61% <50%> (-1.88%)
src/intervals/macros.jl 96% <75%> (+0.16%)
src/parsing.jl 96.15% <96.15%> (ø)
src/intervals/intervals.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daba4ef...7cc6e29. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 19, 2017

Coverage Status

Coverage increased (+0.04%) to 90.495% when pulling 74daca6 on interval_string into 69bd570 on master.

@coveralls
Copy link

coveralls commented Feb 23, 2017

Coverage Status

Coverage increased (+0.04%) to 90.351% when pulling 8c83fb7 on interval_string into daba4ef on master.

@coveralls
Copy link

coveralls commented Feb 24, 2017

Coverage Status

Coverage increased (+0.04%) to 90.351% when pulling 2b72010 on interval_string into daba4ef on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.351% when pulling 7cc6e29 on interval_string into daba4ef on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 90.351% when pulling 7cc6e29 on interval_string into daba4ef on master.

Copy link
Member

@lbenet lbenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work! I'll merge it.

@lbenet lbenet merged commit 11bf694 into master Feb 24, 2017
@dpsanders dpsanders deleted the interval_string branch February 25, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants