Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tblgen bugfixes (keyword arguments and function names) #31

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

jumerckx
Copy link
Collaborator

@jumerckx jumerckx commented Jan 6, 2024

* fix conversion of operations with multiple dots (.) in their name.
@vchuravy vchuravy force-pushed the jm/keyword_arguments branch from e8417c3 to 0e43480 Compare January 16, 2024 16:39
@vchuravy vchuravy mentioned this pull request Jan 16, 2024
@vchuravy
Copy link
Collaborator

@Pangoraw
Copy link
Member

I think this case needs to be handled (operation name starting with a number):

# Error @ /home/runner/work/MLIR.jl/MLIR.jl/src/Dialects/15/ArmNeon.jl:46:10
"""
function 2d_sdot(a::Value, b::Value, c::Value; res::MLIRType, location=Location())
#        ╙ ── Invalid signature in function definition

@vchuravy vchuravy merged commit 72abb74 into JuliaLLVM:main Jan 16, 2024
0 of 4 checks passed
vchuravy pushed a commit that referenced this pull request Jan 16, 2024
* fix conversion of operations with multiple dots (.) in their name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants