regenerate_bindings #44
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
========================================
- Coverage 3.25% 3.03% -0.22%
========================================
Files 107 107
Lines 26059 27923 +1864
========================================
Hits 848 848
- Misses 25211 27075 +1864 ☔ View full report in Codecov by Sentry. |
| @@ -4502,14 +4502,14 @@ spv.GlobalVariable @var2 bind(1, 2) : !spv.ptr<f32, Uniform> | |||
| spv.GlobalVariable @var3 built_in(\"GlobalInvocationId\") : !spv.ptr<vector<3xi32>, Input> | |||
| ``` | |||
| """ | |||
| function GlobalVariable(; type, sym_name, initializer=nothing, binding=nothing, descriptorSet=nothing, builtin=nothing, location=Location()) | |||
| function GlobalVariable(; type, sym_name, initializer=nothing, location_=nothing, binding=nothing, descriptorSet=nothing, builtin=nothing, location=Location()) | |||
There was a problem hiding this comment.
It's slightly odd that we have two location keywords
There was a problem hiding this comment.
Agreed. Maybe the "regular" operation location should be type constrained to IR.Location, there's no good reason I didn't do this yet.
Or would you prefer handling this by using a different name for the attribute, location_attribute or something?
There was a problem hiding this comment.
No strong opinion I will leave that up to you.
mofeing
force-pushed
the
vc/regenerate_bindings
branch
from
1444953 to
ba96ba8
Compare
No description provided.