fix dialect(::Operation) #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
========================================
+ Coverage 2.78% 3.07% +0.29%
========================================
Files 107 107
Lines 26060 26060
========================================
+ Hits 725 802 +77
+ Misses 25335 25258 -77 ☔ View full report in Codecov by Sentry. |
|
I am not sure about the Symbol return type for this function, maybe it should be String? |
I think either would be fine |
Pangoraw
force-pushed
the
Pangoraw-patch-1
branch
from
c07ae31 to
17c27c0
Compare
Pangoraw
force-pushed
the
Pangoraw-patch-1
branch
from
17c27c0 to
c615f40
Compare
vchuravy
reviewed
Jan 24, 2024
|
|
||
| @testset "operation introspection" begin | ||
| IR.context!(IR.Context()) do | ||
| IR.get_or_load_dialect!("linalg") |
There was a problem hiding this comment.
Should this have been arith?
There was a problem hiding this comment.
unfortunately, mlirGetDialectHandle__arith__ does not exist so I had to load transitively with linalg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.