Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator script #68

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Update generator script #68

merged 3 commits into from
Apr 12, 2024

Conversation

Gnimuc
Copy link
Contributor

@Gnimuc Gnimuc commented Apr 8, 2024

Clang v0.18 will be adding an experimental C++ environment for parsing C++ source code.

x-ref: JuliaInterop/Clang.jl#470

@Gnimuc Gnimuc marked this pull request as ready for review April 8, 2024 14:35
@Gnimuc
Copy link
Contributor Author

Gnimuc commented Apr 8, 2024

I only tested it on mac-aarch64, so if it doesn't work on your machine, please report the issue to Clang.jl. ;)

Copy link
Member

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small aesthetic change.

bindings/make.jl Outdated Show resolved Hide resolved
Co-authored-by: Sergio Sánchez Ramírez <[email protected]>
@jumerckx
Copy link
Collaborator

jumerckx commented Apr 9, 2024

Tested on linux-x86-64 (through WSL) and works great!
I also tested on Julia 1.10 without issues so I think we can get rid of the Manifest.toml that was checked in as well?

@mofeing
Copy link
Member

mofeing commented Apr 9, 2024

Tested on linux-x86-64 (through WSL) and works great! I also tested on Julia 1.10 without issues so I think we can get rid of the Manifest.toml that was checked in as well?

I guess so, but we should put a compat bound to Clang.

@mofeing mofeing merged commit ce69c0d into JuliaLLVM:main Apr 12, 2024
3 of 4 checks passed
@mofeing
Copy link
Member

mofeing commented Apr 12, 2024

Thanks @Gnimuc for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants