Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Brutus example on nightly. #75

Merged
merged 8 commits into from
Jun 4, 2024
Merged

Fix Brutus example on nightly. #75

merged 8 commits into from
Jun 4, 2024

Conversation

jumerckx
Copy link
Collaborator

@jumerckx jumerckx commented Jun 2, 2024

Does this make CI happy?

@jumerckx jumerckx changed the title add v17 to API.jl Fix Brutus example on nightly. Jun 2, 2024
@jumerckx jumerckx marked this pull request as draft June 2, 2024 23:07
Pangoraw
Pangoraw reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@Pangoraw Pangoraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

examples/brutus.jl Outdated Show resolved Hide resolved
examples/brutus.jl Outdated Show resolved Hide resolved
jumerckx and others added 2 commits June 3, 2024 10:58
@mofeing
Copy link
Member

mofeing commented Jun 3, 2024

Thanks for fixing the v17 module inclusion. I forgot about that!

@jumerckx
Copy link
Collaborator Author

jumerckx commented Jun 3, 2024 •
edited
Loading

Nightly still segfaults (or some other memory related problem?) when trying to execute the code. I can investigate later today

@jumerckx jumerckx marked this pull request as ready for review June 4, 2024 09:31
@jumerckx
Copy link
Collaborator Author

jumerckx commented Jun 4, 2024

CI is green. I updated Pass.jl with an additional version check. I believe this is good to go?

Pangoraw
Pangoraw approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Pangoraw Pangoraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Sorry I had forgotten that some instructions don't have line info.

@jumerckx jumerckx merged commit b8ab825 into main Jun 4, 2024
6 checks passed
@jumerckx jumerckx deleted the jm/ci_llvm17 branch June 4, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mofeing mofeing mofeing approved these changes

@Pangoraw Pangoraw Pangoraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jumerckx @mofeing @Pangoraw