-
-
Notifications
You must be signed in to change notification settings - Fork 419
Update documentation for installation #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@stevengj This looks good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for leaving this for so long @willingc, would you still be willing to rebase and finish it? No worries if not, I can also do it if that's ok with you.
docs/src/manual/installation.md
Outdated
1. [Download a recent version of Julia.](http://julialang.org/downloads/) | ||
2. Run the installer for the downloaded version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should link to the Install page instead since juliaup is now the recommended way to install Julia: https://julialang.org/install/
docs/src/manual/installation.md
Outdated
to install IJulia. | ||
1. [Download a recent version of Julia.](http://julialang.org/downloads/) | ||
2. Run the installer for the downloaded version. | ||
3. Run the Julia application by double-clicking on the icon. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3. Run the Julia application by double-clicking on the icon. This | |
3. Run the Julia application by double-clicking on the icon or running `julia` in a terminal. This |
@JamesWrigley It would be great if you could get this in! |
Thanks for the ping. It would be great if someone else wants to take it over. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
=======================================
Coverage 15.59% 15.59%
=======================================
Files 15 15
Lines 898 898
=======================================
Hits 140 140
Misses 758 758 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Carol Willing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @willingc, I took the liberty of making some minor changes but otherwise I think this is a nice improvement.
This PR updates the installation documentation based on current Jupyter practices and designates legacy sections where needed. It adds nteract to the intro doc.