Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a further kwarg to PlatformEngines download function #4050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GhostOfElectric
Copy link

@GhostOfElectric GhostOfElectric commented Oct 17, 2024

Doing in the REPL

@1.11> add Plots

can potentially act differently from doing

using Pkg; Pkg.add("Plots")

because (I think) the downloader parameter isn't present in the PlatformEngines.jl file in the download function.

[cf. Downloads EASY_HOOK regression in v1.11.0

@IanButterworth
Copy link
Member

Doing
@1.11> add("Plots")

That's not valid julia pkg mode syntax

@IanButterworth
Copy link
Member

IanButterworth commented Oct 17, 2024

Also, please elaborate on "can potentially act differently"

@GhostOfElectric
Copy link
Author

Is the link enough detail? This is my first pull request, sorry.

@IanButterworth
Copy link
Member

I don't really follow why this is a fix, but I appreciate this is a complicated issue because to properly test the repl mode that is loaded via a repl switch, not using Pkg, julia needs to be built with this version of Pkg.

I'm guessing you haven't done that?

If you have and this is indeed a fix, I think it points to multiple versions of Downloads being loaded by require_stdlib.. but I've not been able to prove that.

@GhostOfElectric
Copy link
Author

I haven't done that no, and I can't really, the need to change the easy_hook settings comes from my work's proxy and I can't build Julia there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants