-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lts tag #32
Add lts tag #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @KristofferC @ararslan ?
I think this is fine. At some point julia-actions/setup-julia#234 should be updated to use this I guess. |
That is somewhat the plan. Hopefully, this will simplify the lts channel logic in juliaup and other tools, and it should be relatively trivial to include additional tags ("rc", "beta",...) with this setup in the future. |
ping @IanButterworth |
I can't merge this because of the skipped required test. @DilumAluthge I assume you added the requirement. Can you take a look/fix the issue? |
You actually should be able to merge it - the "skipped" status doesn't block merging. |
Well, in theory at least. |
CI is running in the merge queue: https://github.com/JuliaLang/VersionsJSONUtil.jl/actions/runs/12995859829 Let's see if it passes. |
@DilumAluthge The pr checks out, though it seems the s3 ci may need to be manually run? https://github.com/JuliaLang/VersionsJSONUtil.jl/actions/runs/12997047361/job/36250700887 |
I'll manually run it. |
This has broken Base Julia Buildkite: https://buildkite.com/julialang/julia-master/builds/44148#0194aa83-523b-42d0-84eb-ffc0760ddfb7 I propose we revert this for now, to fix Base Julia Buildkite, and then we can figure out how to proceed. |
This reverts commit f636fd2.
@@ -23,7 +23,8 @@ permissions: | |||
env: | |||
aws_region: us-east-1 | |||
s3_bucket: julialang2 | |||
|
|||
JULIA_LTS: 1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be JULIA_LTS: '1.10'
It's being parsed as 1.1
"lts": {
"files": [
{
"url": "https://julialang-s3.julialang.org/bin/linux/x64/1.1/julia-1.1.1-linux-x86_64.tar.gz",
"triplet": "x86_64-linux-gnu",
"kind": "archive",
"arch": "x86_64",
"asc": "-----BEGIN PGP SIGNATURE-----\n\niQJLBAABCAA1FiEENnPfUp2QSUd/drN1ZuPH3APW5JUFAlzd++YXHGJ1aWxkYm90\nQGp1bGlhbGFuZy5vcmcACgkQZuPH3APW5JWMdBAAqAkxwCdj90gUsDqfsWhpdzXx\nqx2JEu+Rr+8p5hKeYVaRBNvTt+Z9+YVpLlmGBiJrWqjj7H0Crdko3cWkqewA5O0v\nYdlB1Kvz5Fqmb5pVFBeSf6vu6zQQg3VPdhUlFc2/oS7Bz6XcPpJFLt5t5N+0kzUH\nkB/2INtAIS/KrpkrQcTahzGOr/OIfl9UaBlqoTX8icPCNmVfKRDbPY4gCKa5GX6n\nu9VNixXw04bApvD2BQDVg5ZBWUxpW6plVAPcSXSy86YBW+BPoqCcDY/o2KynBnBy\nz0jDLEz6mpVSwFizQiG17830bbgDeP557pJXeIW0g6LB2k+aISU/4WrpdVk2Z45W\nQnUJgt876dlmyKVmQnuuQCkyNEporDcHqhYVr53hGX3RqzFA6UF1DO89a1T9T73T\nYKrtRAkxl8TADKNij7UjtgtfKKWGRSnhQIttWOZO8V/uzFYEqkWpwSUUVyEt0ZST\nR/F8MnjVc63KzLOeyfKDPQHIE2xdXBkGIKJkDDBsYTd79QqaQOFm/1KchBUVyNur\n5AOrSaHlV/2Y0CQSa6PBdROAxazLpiEdUfSjEz+Yi9aDo6T+S5o+rvY3gmUhVMuo\n2nnLJjR+JE+xCcY8Y2BKaWX30luzOLFTn5/ZhzHGsnyFBuxnYV9hbrAQ/zjfjlFL\nt8ktBsewpRZhaC8SJJ8=\n=yNmM\n-----END PGP SIGNATURE-----\n",
"sha256": "f0a83a139a89a2ccf2316814e5ee1c0c809fca02cbaf4baf3c1fd8eb71594f06",
"size": 89727957,
"version": "1.1.1",
"os": "linux",
"extension": "tar.gz"
},
From https://julialang-s3.julialang.org/bin/versions.json
versions.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix in a follow-up pr once the Buildkite issue is resolved (#36 for now)!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DilumAluthge and I are also discussing that maybe it'd be less breaking to downstream consumers to just make this a field, like "stable" and we enforce that there's only one LTS when generating the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then consumers can just parse and find the first "lts": true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should be relatively trivial to implement, I can reuse some of the logic from the previous pr! I can make such a pr soon if that's okay with you.
Add an "lts" tag to the JSON release feed. This is set via the
JULIA_LTS
variable in the CI workflow, which only requires that the major and minor version numbers match (no need to manually set for every patch release). Tested locally with LocalStack.Closes #2