-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[mmtk-julia] Allow building Julia with variations of the binding #57176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ec92d1
to
12e2954
Compare
12e2954
to
47cf1c5
Compare
cab6d06
to
9f53c2c
Compare
qinsoon
reviewed
Jan 28, 2025
45f710e
to
a0f5c24
Compare
7e309a4
to
d7bc72c
Compare
d5b9db2
to
f890322
Compare
1870113
to
51a7abc
Compare
9aac610
to
20d4373
Compare
d-netto
reviewed
Feb 19, 2025
2ece67b
to
120a7bf
Compare
d-netto
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor comment about error handling when the third-party-GC flag is set to something other than mmtk
.
4d08a18
to
496ebf1
Compare
081dccc
to
bada14e
Compare
bada14e
to
c1cd6cc
Compare
kodiakhq bot
pushed a commit
to JuliaCI/julia-buildkite
that referenced
this pull request
Feb 27, 2025
Adding `WITH_THIRD_PARTY_GC=mmtk` to the MMTk CI to fix it after we merged JuliaLang/julia#57176. Without that, Julia will keep using the stock GC, even though `MMTK_PLAN` has been set. --------- Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables building the mmtk-julia binding with different configurations other than non-moving Immix. While it was already possible to do so when building from source, this should enable using the binaries generated via the latest version from BinaryBuilder (JuliaPackaging/Yggdrasil#10357).
I have also decoupled MMTk from the code, such that it should be an option for a third-party heap. This should be set using
WITH_THIRD_PARTY_GC=mmtk
(inMake.user
or as an environment variable).The different configurations of MMTk can be achieved by setting the variables below (set in
Make.user
, for example):MMTK_PLAN
MMTK_MOVING
MMTK_BUILD
Note that the actual code to support building with moving and sticky immix will be added in future PRs.
I've also added some preliminary documentation in
doc/gc.md
about building Julia with MMTk, including a link to the binding and an small FAQ on what to do if you break the build of Julia+MMTk.