Only strip invariant.load from special pointers #57386
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other backends (in this case NVPTX) require that `invariant.load` metadata is maintained to generate non-coherent loads. Currently, we unconditionally strip that metadata from all loads, since our other uses of it may have become invalid.
vchuravy
force-pushed
the
vc/dont_strip_always_invariant_load
branch
from
8d29aa2 to
7b6646f
Compare
gbaraldi
reviewed
Feb 13, 2025
Co-authored-by: Gabriel Baraldi <[email protected]>
vtjnash
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other backends (in this case NVPTX) require that
invariant.loadmetadata is maintained to generate non-coherent loads.
Currently, we unconditionally strip that metadata from all loads,
since our other uses of it may have become invalid.
x-ref: llvm/llvm-project#112834 JuliaGPU/CUDA.jl#2531