better effects for iterate for Memory and Array
#58755
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
added
iteration
nsajko
force-pushed
the
better_effects_for_array_iterate
branch
from
19ac0f2 to
7989b96
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
NB: I didn't check yet, but if PR #58754 gets merged, it might be possible to just delete the EDIT: just checked, it's true, after #58754 the # no bounds checking, as expected
code_llvm(iterate, Tuple{Vector{Float32}, Int})
code_llvm(iterate, Tuple{Memory{Float32}, Int})
@eval Base function _iterate_array(A::Union{Memory, Array}, i::Int)
@inline
(i - 1)%UInt < length(A)%UInt ? (A[i], i + 1) : nothing
end
@eval Base iterate(A::Memory, i=1) = (@inline; _iterate_array(A, i))
@eval Base iterate(A::Array, i=1) = (@inline; _iterate_array(A, i))
# still no bounds checking!
code_llvm(iterate, Tuple{Vector{Float32}, Int})
code_llvm(iterate, Tuple{Memory{Float32}, Int}) |
nsajko
force-pushed
the
better_effects_for_array_iterate
branch
from
7989b96 to
a8c8cae
Compare
After PR JuliaLang#58754 the bounds checking is eliminated by LLVM even without asserting `inbounds`, so delete `inbounds` to allow the `noub` effect to be inferred. Also deduplicate and test for good effect inference.
nsajko
force-pushed
the
better_effects_for_array_iterate
branch
from
f5b3026 to
0e38f1b
Compare
nsajko
added
needs nanosoldier run
oscardssmith
approved these changes
Jun 19, 2025
nsajko
added
merge me
mbauman
reviewed
Jun 20, 2025
| iterate(A::Memory, i=1) = (@inline; (i - 1)%UInt < length(A)%UInt ? (@inbounds A[i], i + 1) : nothing) | ||
| function _iterate_array(A::Union{Memory, Array}, i::Int) | ||
| @inline | ||
| (i - 1)%UInt < length(A)%UInt ? (A[i], i + 1) : nothing |
There was a problem hiding this comment.
Could (should?) this also become _checkbounds_array(Bool, A, i)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #58754 the bounds checking is eliminated by LLVM even without
@inbounds, so delete@inboundsto allow thenoubeffect to be inferred.Also deduplicate and test for good effect inference.