inform compiler about local variable definedness #58778
Merged
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/local-var-undef
branch
from
1f1151e to
f2b3886
Compare
vchuravy
reviewed
Jun 19, 2025
| @@ -208,6 +204,8 @@ function multiq_deletemin() | |||
| end | |||
| end | |||
|
|
|||
| @assert @isdefined(rn1) "Assertion to tell the compiler about the definedness of this variable" | |||
There was a problem hiding this comment.
Should this be a comment instead of a string?
There was a problem hiding this comment.
Maybe, but I'm not sure what to put for the assertion string. Any idea?
JET's new analysis pass now detects local variables that may be undefined, which has revealed such issues in several functions within Base (#58762). This commit addresses local variables whose definedness the compiler cannot properly determine, primarily in functions reachable from JET's test suite. No functional changes are made.
aviatesk
force-pushed
the
avi/local-var-undef
branch
from
f2b3886 to
60b0813
Compare
|
I'll proceed with this for now. |
aviatesk
added a commit
that referenced
this pull request
Jun 20, 2025
JET's new analysis pass now detects local variables that may be undefined, which has revealed such issues in several functions within Base (#58762). This commit addresses local variables whose definedness the compiler cannot properly determine, primarily in functions reachable from JET's test suite. No functional changes are made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JET's new analysis pass now detects local variables that may be undefined, which has revealed such issues in several functions within Base (#58762).
This commit addresses local variables whose definedness the compiler cannot properly determine, primarily in functions reachable from JET's test suite. No functional changes are made.