Skip to content

Fix precompiling when there's no manifest #59212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

Fix precompiling when there's no manifest #59212

merged 3 commits into from
Aug 7, 2025
+82 −11

Conversation

IanButterworth
Copy link
Member

Fixes #59206

Here there's no Manifest.toml in the Pkg repo

% ./julia --start=no --project=../Pkg.jl -q -ie "using Pkg, REPL"
Precompiling Pkg finished.
  1 dependency successfully precompiled in 37 seconds
Precompiling REPLExt finished.
  1 dependency successfully precompiled in 5 seconds
julia>

@IanButterworth IanButterworth added packages Package management and loading needs tests Unit tests are required for this change labels Aug 5, 2025
@IanButterworth IanButterworth removed the needs tests Unit tests are required for this change label Aug 6, 2025
@IanButterworth
Copy link
Member Author

@KristofferC I'd appreciate another set of eyes on this. It's breaking Pkg CI so good to get in quick.

@IanButterworth
Copy link
Member Author

I'll merge as this needs fixing to unblock e.g. Pkg CI, but review still appreciated

@IanButterworth IanButterworth merged commit e4a3a2a into JuliaLang:master Aug 7, 2025
7 of 8 checks passed
@IanButterworth IanButterworth deleted the ib/fix_precompile_no_manifest branch August 7, 2025 12:47
@aviatesk aviatesk mentioned this pull request Oct 12, 2025
Merged
@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Oct 12, 2025
KristofferC pushed a commit that referenced this pull request Oct 12, 2025
@IanButterworth @KristofferC
Fix precompiling when there's no manifest (#59212)
e7df962 
(cherry picked from commit e4a3a2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees

No one assigned

Labels

backport 1.12 Change should be backported to release-1.12 packages Package management and loading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Precompiling broken when no manifest

2 participants

@IanButterworth @KristofferC