Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviving #84 #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reviving #84 #126

wants to merge 1 commit into from

Conversation

mschauer
Copy link
Member

The documentation for stirlings1 and stirlings2 indicates that they can use BigInts if provided with such as argument. However the existing functions specify n and k arguments to be Int. This patch allows support for BigInt integers without breaking type consistency of return types, and also provides for some memoization, since otherwise the functions, since they are recursive, can be slow when handling very large integers. (@wherrera10 in #84)

> The documentation for stirlings1 and stirlings2 indicates that they can use BigInts if provided with such as argument. However the existing functions specify n and k arguments to be Int. This patch allows support for BigInt integers without breaking type consistency of return types, and also provides for some memoization, since otherwise the functions, since they are recursive, can be slow when handling very large integers.

(credit https://github.com/wherrera10)
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 96.85% // Head: 96.89% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (55725ed) compared to base (d1b633b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   96.85%   96.89%   +0.03%     
==========================================
  Files           7        7              
  Lines         700      708       +8     
==========================================
+ Hits          678      686       +8     
  Misses         22       22              
Impacted Files Coverage Δ
src/numbers.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mschauer mschauer mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant