Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Enzyme to "extras" for testing, docs #115

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Aug 1, 2024

This adds the new weakdep Enzyme to the "extras" section and for testing.

Also adds a compat entry for the stdlib LinearAlgebra since that is required nowadays.

bumps the Julia version requirement to 1.6 since that is needed by Enzyme (a test dependency even though it is optional for installation), and it is a pain to continue to support 1.2 with this dependency present. Not much point in supporting ancient Julia versions these days.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (b8ee1d2) to head (77c211b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   93.43%   92.23%   -1.21%     
==========================================
  Files           8        8              
  Lines         762      773      +11     
==========================================
+ Hits          712      713       +1     
- Misses         50       60      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj
Copy link
Member Author

stevengj commented Aug 2, 2024

Looks like Julia's inference is failing for to_segbuf on Julia 1.6–1.8. I'm not sure it's worth it to fix this — it still works but is suboptimal on old Julia versions (though the test passed in Julia 1.2 IIRC!), and is type-stable on newer Julia versions. Better to just disable the test for versions < 1.9.

@stevengj stevengj merged commit 89c6f25 into master Aug 2, 2024
11 of 12 checks passed
@stevengj stevengj deleted the stevengj-patch-1 branch August 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant