Use BaseType.base_numeric_type instead of Base.one to get base scalar type

[MilesCranmer]

x-ref #88, JuliaPhysics/Measurements.jl#155, SymbolicML/DynamicQuantities.jl#40

I've confirmed that with this change as well as the intended change to make AbstractQuantity <: Number, DynamicQuantities.jl is now compatible with QuadGK.jl. And this allows me to keep Base.one(::Quantity) -> Quantity.

BaseType.jl should already work for all types I can think of due to the default behavior, but feel free to wait until more interfaces are explicitly declared (e.g., JuliaPhysics/Measurements.jl#155)

[giordano]

And this allows me to keep Base.one(::Quantity) -> Quantity.

Isn't that violating the semantic of Base.one?

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (10bc1a1) 98.16% compared to head (bdd31ec) 98.16%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files           6        6           
  Lines         599      599           
=======================================
  Hits          588      588           
  Misses         11       11           

Files Changed	Coverage Δ
src/QuadGK.jl	100.00% <ø> (ø)
src/gausskronrod.jl	98.37% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MilesCranmer]

Unitful.Quantity yes, but DynamicQuantities.Quantity no.

See the discussion in SymbolicML/DynamicQuantities.jl#40 for details.

[MilesCranmer]

@stevengj wondering if you could look at merging this? It is completely compatible with existing types and also adds support for DualNumbers and DynamicQuantities (for which one is used for something different)

[MilesCranmer]

FYI @mikeingold once this PR merges, you will be able to use DynamicQuantities for QuadGK.

[MilesCranmer]

FYI @stevengj this is now in Measurements.jl as an extension, and also compatible with DualNumbers, Unitful, and DynamicQuantities (as well as a nested combination of any of those)