-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized binomial coefficient #293
base: master
Are you sure you want to change the base?
Conversation
The make.jl documentation script throws tons of errors. Some are regarding the newly implemented function Excerpts from the warnings:
Any idea what I did wrong? |
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 88.17% 88.22% +0.04%
==========================================
Files 11 11
Lines 2630 2632 +2
==========================================
+ Hits 2319 2322 +3
+ Misses 311 310 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
A Todo list (taken from the issue #282)
I didn't find a good link to dlmf. If anybody finds an appropriate link I can include it. I guess it is not that important? The Documenter.jl script doesn't pick up the function documentation. I already created a topic at discourse.julialang.org. |
|
||
See also [`beta(a,b)`](@ref SpecialFunctions.beta). | ||
""" | ||
Base.binomial(x::Number, y::Number) = inv((x+1) * beta(x-y+1, y+1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type piracy; we would need to use a different name like genbinomial
This is a pr wrt to issue #282 .
Binomial coefficient is generalized for real/complex arguments using the
beta
function.