[S2Geography] New recipe #9450
[S2Geography] New recipe #9450
Conversation
There was a problem hiding this comment.
Can you please upstream this patch?
There was a problem hiding this comment.
I opened a PR a while ago google/s2geometry#379 and I just saw someone commented there - will see what they think. But for this version is this reasonable to get in?
There was a problem hiding this comment.
Doh, never mind, this is for s2geography. I'll talk to the author there to try and upstream this.
Co-authored-by: Mosè Giordano <[email protected]>
|
@asinghvi17 hi there, are you still interested in completing this? |
|
Hey @fingolfin, thanks for the ping! I marked this as ready for review and am re-running CI now. |
|
@asinghvi17 that won't work, you'll have to rebase this on latest master, or merge latest master into it |
|
Somehow it doesn't let me merge online, so I will do that locally tomorrow |
|
I merged |
| # from the JLLs. | ||
| script = raw""" | ||
| cd ${WORKSPACE}/srcdir/s2geography | ||
| atomic_patch -p1 ../patches/msvc_to_win32_target.patch |
There was a problem hiding this comment.
This failed because your patch was in bundled/msvc_to_win32_target.patch not in bundled/patches/msvc_to_win32_target.patch -- I've moved it now
3 participants
https://github.com/paleolimbot/S2Geography is a wrapper around S2Geometry that provides a GEOS-like C++ API around the S2 objects which often don't act like geospatial objects.
This PR is still very WIP and I'm experimenting quite a bit with the build script following the lessons from my last PR for S2Geometry.