Conversation
14d3316 to
3ca31dc
Compare
25b9a70 to
a76fb42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've long been displeased about having to say
using DaggerGPUto get GPU support code loaded, which used to be necessary before package extensions existed. I also think that having such important code live outside of the core Dagger repo makes it hard to keep the GPU code up to date and working properly as Dagger itself evolves. This PR corrects these issues by moving all GPU support code into the Dagger repo, and wiring up CI to keep it regularly tested.Mostly, things are the same as before, with the exception of not needing
using DaggerGPU, and with functions being under theDagger.namespace instead. I've also made a few slight name changes, but I'll keep the original names in DaggerGPU.jl (with deprecation warnings) to ensure existing code keeps working.Also,
Dagger.Kernelno longer automatically synchronizes, and instead users can callDagger.gpu_synchronize(...)to synchronize Dagger's background queues/streams. Having a forced synchronization basically negated the usefulness ofDagger.Kernel, but was necessary before we did queue/stream tracking. Now you can rely on Dagger to handle synchronization across Dagger tasks automatically, and only need to callDagger.gpu_synchronize(...)when running GPU code outside of Dagger, to force Dagger to synchronize its background streams/queues.Todo: