Skip to content

add other profiles (i.e. heap snapshot and allocation profiles) into debug super-endpoint #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jun 12, 2024

Ensures that all profiles exposed in the package are available in the debug super-endpoint.

@d-netto d-netto requested a review from NHDaly June 12, 2024 18:21
@d-netto d-netto force-pushed the dcn-other-profiles-in-debug-super-endpoint branch 3 times, most recently from 7f4d097 to b88f535 Compare June 12, 2024 18:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.44%. Comparing base (ffd6913) to head (d309830).

Current head d309830 differs from pull request most recent head b88f535

Please upload reports for the commit b88f535 to get more accurate results.

Files Patch % Lines
src/ProfileEndpoints.jl 85.71% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   90.00%   81.44%   -8.56%     
==========================================
  Files           1        1              
  Lines         190      221      +31     
==========================================
+ Hits          171      180       +9     
- Misses         19       41      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-netto d-netto force-pushed the dcn-other-profiles-in-debug-super-endpoint branch 3 times, most recently from f4b435f to 3181014 Compare June 12, 2024 18:40
@d-netto d-netto force-pushed the dcn-other-profiles-in-debug-super-endpoint branch from 3181014 to f544204 Compare June 12, 2024 18:49
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@d-netto d-netto merged commit 6deac35 into main Jun 13, 2024
10 of 12 checks passed
@d-netto d-netto deleted the dcn-other-profiles-in-debug-super-endpoint branch June 13, 2024 16:37
@d-netto d-netto mentioned this pull request Jun 13, 2024
d-netto added a commit that referenced this pull request Jun 13, 2024
Since we added new functionality to the debug super-endpoint in #44.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants