-
Notifications
You must be signed in to change notification settings - Fork 495
New version: Makie v0.24.0 #133351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
New version: Makie v0.24.0 #133351
Conversation
* Update CHANGELOG.md * clean up some TODO comments * clean up move_to * please runic * cleanup changelog * try to fight CI OOM for relocatability * clean up file and name for plot drawing implementation * follow (W)GLMakie naming for entry point into plot drawing functions * up ComputePipeline version * ruuuuunicgit add .! * less processes? * try to make test more stable * change number * ok, just increase threshold --------- Co-authored-by: Simon <[email protected]>
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. AutoMerge Guidelines which are not met ❌
2. Needs action: here's what to do next
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
[noblock] the changes to add subdir are desired and required. Will fix the other issues |
UUID: ee78f7c-11fb-53f2-987a-cfe4a2b5a57a Repo: https://github.com/MakieOrg/Makie.jl.git Tree: 59226215851d7d304ed6e35a56a932d562a34f5f Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
b12eac2
to
58b7475
Compare
* restrict computepipeline version * Makie needs a license * update CHANGELOG * correct version
https://github.com/JuliaRegistries/General/blob/0727c14fba932cf466f0597a6c68a629d0abeab0/README.md#how-do-i-move-a-subdirectory-package-to-its-own-repository in particular point 2. And to be extremely clear, you must do the test checking out this branch of the registry. |
the repository is the same so I guess that makes all points alright? |
No |
If it’s the same repo it should be ok, no? Though it doesn’t hurt to run the script and check the versions |
But the directory changed. |
But the old versions are by tree hash so if the history didn’t change, the old versions should be accessible forever |
For the registry, after this change there's no "before and after": all versions are in a subdirectory. I genuinely don't know how Pkg handles this, this is why I'm asking someone interested in sorting this out to demonstrate that all versions are still available. |
what I'm saying is I know Pkg does not use the subdir parameter from the registry for resolving releases, only for add-with-branch and situations like that where it does not have a tree hash. So the script will pass since it only checks releases. This PR will break add-with-branch to add old branches that have Makie not in the subdirectory but I think it's ok and we've allowed this before. I'm not at my computer otherwise I'd just run the script to demonstrate. |
Uh oh!
There was an error while loading. Please reload this page.