Skip to content

nlp doc change #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2025
Merged

nlp doc change #456

merged 6 commits into from
Jun 28, 2025

Conversation

arnavk23
Copy link
Contributor

Removed outdated call to finalize(nlp) and recommended using the CUTEstModel("PROBLEM") do nlp ... end syntax for automatic cleanup as mentioned #275, thus this Closes #442.

  • Also want to add that we don't need a tutorial.md when the contents of the file is an introduction video and it is already mentioned on the readme.md file.

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.23%. Comparing base (f2ad6a4) to head (4bc57e7).
Report is 152 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #456       +/-   ##
===========================================
- Coverage   89.11%   74.23%   -14.88%     
===========================================
  Files           5        7        +2     
  Lines         790     1669      +879     
===========================================
+ Hits          704     1239      +535     
- Misses         86      430      +344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amontoison
Copy link
Member

amontoison commented Jun 28, 2025

Did you try CUTEstModel{Float64}("CHAIN") do nlp ... end in a terminal to check if it works.
I am at the airport but these other terminals will not help us to find the issue :)

@arnavk23
Copy link
Contributor Author

@amontoison I think now this will pass all the checks.

@amontoison
Copy link
Member

Thank you @arnavk23 !
I will merge the PR if all tests passed.

@amontoison amontoison merged commit 1f405ca into JuliaSmoothOptimizers:main Jun 28, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorials using CUTEst
2 participants