Update docstring in src/model.jl #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amontoison Please review the changes made here. |
amontoison
approved these changes
Jun 30, 2025
amontoison
reviewed
Jun 30, 2025
|
I removed the last sentence because we don't provide (yet) a way to specify a custom "tag" when we create the CUTEstModel. |
amontoison
merged commit 780dc56
into
JuliaSmoothOptimizers:main
15 of 16 checks passed
|
Thank you! |
|
Thank you @amontoison for the encouragement. I will keep working on more. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
===========================================
- Coverage 89.11% 74.23% -14.88%
===========================================
Files 5 7 +2
Lines 790 1669 +879
===========================================
+ Hits 704 1239 +535
- Misses 86 430 +344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to clarify an important corner case when using multiple CUTEstModel instances.
This note helps users understand:
No code change; documentation only.
Closes #440