Skip to content

Update core_interface.jl #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2025
Merged

Conversation

arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Jul 7, 2025

This PR adds chsprod, chjprod, and cohprods routines to the CUTEst core_interface.jl as C-compatible function wrappers.
Adds interface bindings for:

  • cutest_chsprod
  • cutest_chjprod
  • cutest_cohprods

Closes #347

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 73.95%. Comparing base (f2ad6a4) to head (6182154).
Report is 155 commits behind head on main.

Files with missing lines Patch % Lines
src/core_interface.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #461       +/-   ##
===========================================
- Coverage   89.11%   73.95%   -15.16%     
===========================================
  Files           5        7        +2     
  Lines         790     1678      +888     
===========================================
+ Hits          704     1241      +537     
- Misses         86      437      +351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23
You forgot to the docstring in core.md:

┌ Error: 3 docstrings not included in the manual:
│ 
│     CUTEst.chjprod
│     CUTEst.cohprods
│     CUTEst.chsprod
│ 
│ These are docstrings in the checked modules (configured with the modules keyword)
│ that are not included in canonical @docs or @autodocs blocks.

@arnavk23 arnavk23 requested a review from amontoison July 8, 2025 08:16
@arnavk23
Copy link
Contributor Author

arnavk23 commented Jul 8, 2025

@amontoison made the required changes. it should now be passing alll the checks.

@arnavk23
Copy link
Contributor Author

arnavk23 commented Jul 8, 2025

@amontoison Passes all the checks, only failing the codecov check.

@amontoison
Copy link
Member

The codecov failure is because you didn't added unit tests with the new interfzce routines.
However I can merge the current work, thanks you!

@amontoison amontoison merged commit 5135f96 into JuliaSmoothOptimizers:main Jul 8, 2025
18 of 20 checks passed
@arnavk23 arnavk23 deleted the patch-1 branch July 8, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface cutest_cint_chsprod, cutest_cint_chjprod and cutest_cint_cohprods
2 participants