-
Notifications
You must be signed in to change notification settings - Fork 21
Add counter validation against CUTEst native reporting #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Potential fix for code scanning alert no. 8: Workflow does not contain permissions
@amontoison Please review the changes made here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! I made a couple of comments.
test/test_counter.jl
Outdated
|
||
Get the evaluation counters from CUTEst's native reporting functions. | ||
""" | ||
function get_cutest_counters(nlp::CUTEstModel{T}) where T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it is doable to test all the fields of Counters
https://github.com/JuliaSmoothOptimizers/NLPModels.jl/blob/d258d3550db5ebfb828a1edc049d1185a91587b7/src/nlp/counters.jl#L14 ?
If not it should be described here which fields you didn't manage to do, and we will create another issue after this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to test 17 out of the 20 counter fields, started an issue for the missing 3 at #465
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
===========================================
- Coverage 89.11% 73.95% -15.16%
===========================================
Files 5 7 +2
Lines 790 1678 +888
===========================================
+ Hits 704 1241 +537
- Misses 86 437 +351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
@tmigot If you can, Please also review this pr as I think this is very close to merging. |
This PR implements comprehensive validation of evaluation counters by comparing CUTEst.jl's internal counter tracking with CUTEst's native reporting functions.
test/test_counters.jl
: Complete test suite for counter validationget_cutest_counters()
: Utility function that extracts counters from CUTEst's native reporting functionstest_counter_validation()
: Main test function with separate validation for unconstrained and constrained problemsCloses #278