Manual NLSModel #37
Draft
Manual NLSModel #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs more unit tests. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a manual NLSModel (Nonlinear Least Squares Model) implementation to the ManualNLPModels package. The implementation allows users to define NLS problems by providing residual functions and optional Jacobian operations.
- Adds a new
NLSModelstruct and constructor for creating least-squares optimization problems - Implements core NLS API methods for residual evaluation, Jacobian products, and structure queries
- Includes comprehensive test coverage to verify error handling for unimplemented methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/structure.jl | Exports NLSModel and adds the struct definition with constructor |
| src/nls_api.jl | Implements NLS API methods for residual and Jacobian operations |
| src/ManualNLPModels.jl | Includes the new nls_api.jl file |
| test/notimplemented.jl | Adds tests for NLSModel error handling and method availability |
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.