Avoid views in jtprod!

[tmigot]

This would solve JuliaSmoothOptimizers/NLPModelsModifiers.jl#77

using NLPModels, NLPModelsModifiers, NLPModelsTest
nlp = NLSLC()
nls = FeasibilityFormNLS(nlp)
x = get_x0(nls)
y = get_y0(nls)
Jtv = similar(x)
jtprod!(nls, x, y, Jtv)
@allocated jtprod!(nls, x, y, Jtv) # 0

Connected to #384 .

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.25%. Comparing base (361ccb7) to head (53d6aba).

Files	Patch %	Lines
src/nlp/api.jl	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
- Coverage   99.50%   99.25%   -0.25%     
==========================================
  Files          13       13              
  Lines         803      807       +4     
==========================================
+ Hits          799      801       +2     
- Misses          4        6       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsModifiers.jl
NLPModelsTest.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverCore.jl
SolverTest.jl
SolverTools.jl

[tmigot]

The breakage fails because of the new releases of NLPModelsModifiers and to be NLPModelsTest ; I will re-run this when they arrive.