Remove test on counters if redefined

[tmigot]

Addind linear_api = true to the models, there is only this blocking.

In particular, because of JuliaSmoothOptimizers/NLPModels.jl#384 we sometimes re-implement without using the linear/nonlinear functions. This works fine except for the counters.

For instance, reimplementing jtprod, all the situations are possible:

• don't use jtprod_lin or jtprod_nln
• use jtprod_nln only (say you have the linear structure stored in the model already)
• use both jtprod_lin and jtprod_nln

So, I suggest we just skip.

• ADNLPModels https://github.com/JuliaSmoothOptimizers/ADNLPModels.jl/tree/add-linear-tests
• QuadraticModels https://github.com/JuliaSmoothOptimizers/QuadraticModels.jl/tree/add-linear-tests
• LLSModels https://github.com/JuliaSmoothOptimizers/LLSModels.jl/tree/add-linear-tests
• CUTEst https://github.com/JuliaSmoothOptimizers/CUTEst.jl/tree/add-linear-tests
• NLPModelsJuMP Add linear tests NLPModelsJuMP.jl#131

[codecov]

Codecov Report

Base: 99.22% // Head: 99.18% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (3d3ba0b) compared to base (a0a57bc).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   99.22%   99.18%   -0.04%     
==========================================
  Files          25       25              
  Lines        2957     2959       +2     
==========================================
+ Hits         2934     2935       +1     
- Misses         23       24       +1     

Impacted Files	Coverage Δ
src/nlp/consistency.jl	99.03% <88.88%> (-0.16%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

Package name	latest	stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCISolver.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
PDENLPModels.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

[dpo]

Makes sense. Thanks.