Skip to content

Replace deprecated lfact(x)#1857

Merged
devmotion merged 1 commit intoJuliaStats:masterfrom
THargreaves:master
May 29, 2024
Merged

Replace deprecated lfact(x)#1857
devmotion merged 1 commit intoJuliaStats:masterfrom
THargreaves:master

Conversation

@THargreaves
Copy link
Contributor

lfact has been replaced by logfactorial since at least version 1.2 of SpecialFunctions.jl, which is the earliest compatible version with Distributions.jl.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.96%. Comparing base (f852803) to head (3a9cfb8).

Files Patch % Lines
src/univariate/continuous/ksdist.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1857   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         144      144           
  Lines        8647     8647           
=======================================
  Hits         7433     7433           
  Misses       1214     1214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@devmotion devmotion merged commit 24de004 into JuliaStats:master May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants